Commit 00236a2d authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf test: Allow skip for all metrics test 



Some Intel TMA metrics compute a ratio that may divide by 0, which
causes the metric not to print. This happens for metrics with FP_ARITH
events. If we see these events in the result and would otherwise fail,
then switch to a skip.

Also, don't early exit when processing metrics.

Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Zhengjun Xing <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20220201015858.1226914-2-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 59835f55

tools/perf/tests/shell/stat_all_metrics.sh

+8 −2
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ 


set -e



err=0

for m in $(perf list --raw-dump metrics); do

  echo "Testing $m"

  result=$(perf stat -M "$m" true 2>&1)
@@ -14,9 +15,14 @@ for m in $(perf list --raw-dump metrics); do 
    if [[ ! "$result" =~ "$m" ]]; then

      echo "Metric '$m' not printed in:"

      echo "$result"

      exit 1

      if [[ "$result" =~ "FP_ARITH" && "$err" != "1" ]]; then

        echo "Skip, not fail, for FP issues"

        err=2

      else

        err=1

      fi

    fi

  fi

done



exit 0
 
exit "$err"