Commit 00a72db7 authored by Nuno Sa's avatar Nuno Sa Committed by Jonathan Cameron
Browse files

iio: adis16475: do not return ints in irq handlers 



On an IRQ handler we should not return normal error codes as 'irqreturn_t'
is expected.

This is done by jumping to the 'check_burst32' label where we return
'IRQ_HANDLED'. Note that it is fine to do the burst32 check in this
error path. If we have proper settings to apply burst32, we might just
do the setup now so that the next sample already uses it.

Fixes: fff7352b ("iio: imu: Add support for adis16475")
Reviewed-by: default avatarAlexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: default avatarNuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210427085454.30616-2-nuno.sa@analog.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 9cc9806e

drivers/iio/imu/adis16475.c

+1 −1
Original line number Diff line number Diff line
@@ -1068,7 +1068,7 @@ static irqreturn_t adis16475_trigger_handler(int irq, void *p) 


	ret = spi_sync(adis->spi, &adis->msg);

	if (ret)

		return ret;

		goto check_burst32;



	adis->spi->max_speed_hz = cached_spi_speed_hz;

	buffer = adis->buffer;