Commit 01835fad authored by Srikant Ritolia's avatar Srikant Ritolia Committed by Alexandre Belloni
Browse files

rtc: ds1374: Merge conditional + WARN_ON() 



WARN_ON does both these things in one statement.
Using a better pattern with WARN_ON().

Signed-off-by: default avatarSrikant Ritolia <s.ritolia@samsung.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 1c02cbfe

drivers/rtc/rtc-ds1374.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -89,10 +89,8 @@ static int ds1374_read_rtc(struct i2c_client *client, u32 *time, 
	int ret;

	int ret;

	int i;

	int i;





	if (nbytes > 4) {

	if (WARN_ON(nbytes > 4))

		WARN_ON(1);

		return -EINVAL;

		return -EINVAL;

	}





	ret = i2c_smbus_read_i2c_block_data(client, reg, nbytes, buf);

	ret = i2c_smbus_read_i2c_block_data(client, reg, nbytes, buf);