Commit 02ca527a authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

tcp: Fix a data-race around sysctl_tcp_app_win. 



While reading sysctl_tcp_app_win, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 58ebb1c8

net/ipv4/tcp_input.c

+1 −1
Original line number Diff line number Diff line
@@ -534,7 +534,7 @@ static void tcp_grow_window(struct sock *sk, const struct sk_buff *skb, 
 */

static void tcp_init_buffer_space(struct sock *sk)

{

	int tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win;

	int tcp_app_win = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_app_win);

	struct tcp_sock *tp = tcp_sk(sk);

	int maxwin;