Commit 033c9786 authored by Hans de Goede's avatar Hans de Goede Committed by Jiri Kosina
Browse files

HID: lenovo: Remove lenovo_led_brightness_get() 



The led_classdev already contains a cached value of the last set
brightness, the brightness_get callback is only meant for LED drivers
which can read back the actual / current brightness from the hardware.

Since lenovo_led_brightness_get() just returns the last set value
it does not add any functionality, so we can just remove it.

Reviewed-by: default avatarMarek Behún <kabel@kernel.org>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 34348a86

drivers/hid/hid-lenovo.c

+0 −18
Original line number Diff line number Diff line
@@ -774,22 +774,6 @@ static void lenovo_led_set_tpkbd(struct hid_device *hdev) 
	hid_hw_request(hdev, report, HID_REQ_SET_REPORT);

}



static enum led_brightness lenovo_led_brightness_get(

			struct led_classdev *led_cdev)

{

	struct device *dev = led_cdev->dev->parent;

	struct hid_device *hdev = to_hid_device(dev);

	struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);

	int led_nr = 0;



	if (led_cdev == &data_pointer->led_micmute)

		led_nr = 1;



	return data_pointer->led_state & (1 << led_nr)

				? LED_FULL

				: LED_OFF;

}



static int lenovo_led_brightness_set(struct led_classdev *led_cdev,

			enum led_brightness value)

{
@@ -837,7 +821,6 @@ static int lenovo_register_leds(struct hid_device *hdev) 
	snprintf(name_micm, name_sz, "%s:amber:micmute", dev_name(&hdev->dev));



	data->led_mute.name = name_mute;

	data->led_mute.brightness_get = lenovo_led_brightness_get;

	data->led_mute.brightness_set_blocking = lenovo_led_brightness_set;

	data->led_mute.flags = LED_HW_PLUGGABLE;

	data->led_mute.dev = &hdev->dev;
@@ -846,7 +829,6 @@ static int lenovo_register_leds(struct hid_device *hdev) 
		return ret;



	data->led_micmute.name = name_micm;

	data->led_micmute.brightness_get = lenovo_led_brightness_get;

	data->led_micmute.brightness_set_blocking = lenovo_led_brightness_set;

	data->led_micmute.flags = LED_HW_PLUGGABLE;

	data->led_micmute.dev = &hdev->dev;