Commit 0431f080 authored by Aleh Suprunovich's avatar Aleh Suprunovich Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723au: fix sparse warning 



drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol
'rtl8723a_EfusePgPacketRead' was not declared. Should it be static?

Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current
staging code.

Before, it was available as 'static s32 Hal_EfusePgPacketRead',
but code that was using it removed, in the same commit as rename and
signature change to 'bool rtl8723a_EfusePgPacketRead' has taken place.

Signed-off-by: default avatarAleh Suprunovich <br@ahlamon.org>
Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6b1b4cad

drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c

+0 −78
Original line number Diff line number Diff line
@@ -743,84 +743,6 @@ u16 rtl8723a_EfuseGetCurrentSize_BT(struct rtw_adapter *padapter) 
	return retU2;

}



bool

rtl8723a_EfusePgPacketRead(struct rtw_adapter *padapter, u8 offset, u8 *data)

{

	u8 efuse_data, word_cnts = 0;

	u16 efuse_addr = 0;

	u8 hoffset = 0, hworden = 0;

	u8 i;

	u8 max_section = 0;

	s32 ret;



	if (data == NULL)

		return false;



	EFUSE_GetEfuseDefinition23a(padapter, EFUSE_WIFI, TYPE_EFUSE_MAX_SECTION,

				 &max_section);

	if (offset > max_section) {

		DBG_8723A("%s: Packet offset(%d) is illegal(>%d)!\n",

			  __func__, offset, max_section);

		return false;

	}



	memset(data, 0xFF, PGPKT_DATA_SIZE);

	ret = true;



	/*  */

	/*  <Roger_TODO> Efuse has been pre-programmed dummy 5Bytes at the

	    end of Efuse by CP. */

	/*  Skip dummy parts to prevent unexpected data read from Efuse. */

	/*  By pass right now. 2009.02.19. */

	/*  */

	while (AVAILABLE_EFUSE_ADDR(efuse_addr)) {

		if (efuse_OneByteRead23a(padapter, efuse_addr++, &efuse_data) ==

		    _FAIL) {

			ret = false;

			break;

		}



		if (efuse_data == 0xFF)

			break;



		if (EXT_HEADER(efuse_data)) {

			hoffset = GET_HDR_OFFSET_2_0(efuse_data);

			efuse_OneByteRead23a(padapter, efuse_addr++, &efuse_data);

			if (ALL_WORDS_DISABLED(efuse_data)) {

				DBG_8723A("%s: Error!! All words disabled!\n",

					  __func__);

				continue;

			}



			hoffset |= ((efuse_data & 0xF0) >> 1);

			hworden = efuse_data & 0x0F;

		} else {

			hoffset = (efuse_data >> 4) & 0x0F;

			hworden = efuse_data & 0x0F;

		}



		if (hoffset == offset) {

			for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {

				/* Check word enable condition in the section */

				if (!(hworden & (0x01 << i))) {

					ReadEFuseByte23a(padapter, efuse_addr++,

						      &efuse_data);

					data[i * 2] = efuse_data;



					ReadEFuseByte23a(padapter, efuse_addr++,

						      &efuse_data);

					data[(i * 2) + 1] = efuse_data;

				}

			}

		} else {

			word_cnts = Efuse_CalculateWordCnts23a(hworden);

			efuse_addr += word_cnts * 2;

		}

	}



	return ret;

}



void rtl8723a_read_chip_version(struct rtw_adapter *padapter)

{

	u32 value32;