Commit 06050811 authored by Marco Felsch's avatar Marco Felsch Committed by Mauro Carvalho Chehab
Browse files

media: i2c: tc358746: fix missing return assignment 



It was intended to return an error if tc358746_update_bits() call fail.
Fix this by storing the return code.

Addresses-Coverity-ID: 1527252 ("Control flow issues")

Reported-by: default avatarcoverity-bot <keescook+coverity-bot@chromium.org>
Fixes: 80a21da3 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
Signed-off-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent dd74ed6c

drivers/media/i2c/tc358746.c

+1 −1
Original line number Diff line number Diff line
@@ -406,7 +406,7 @@ tc358746_apply_pll_config(struct tc358746 *tc358746) 


	val = PLL_FRS(ilog2(post)) | RESETB | PLL_EN;

	mask = PLL_FRS_MASK | RESETB | PLL_EN;

	tc358746_update_bits(tc358746, PLLCTL1_REG, mask, val);

	err = tc358746_update_bits(tc358746, PLLCTL1_REG, mask, val);

	if (err)

		return err;