Commit 061115fb authored Jul 23, 2023 by Dongliang Mu Committed by Kalle Valo Jul 25, 2023

wifi: ath9k: fix printk specifier



Smatch reports:

ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer

Fix it by modifying %lx to %p in the printk format string.

Note that with this change, the pointer address will be printed as a
hashed value by default. This is appropriate because the kernel
should not leak kernel pointers to user space in an informational
message. If someone wants to see the real address for debugging
purposes, this can be achieved with the no_hash_pointers kernel option.

Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230723040403.296723-1-dzm91@hust.edu.cn

parent 1301783c

drivers/net/wireless/ath/ath9k/ahb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -132,8 +132,8 @@ static int ath_ahb_probe(struct platform_device *pdev)

		ah = sc->sc_ah;
		ath9k_hw_name(ah, hw_name, sizeof(hw_name));
		wiphy_info(hw->wiphy, "%s mem=0x%lx, irq=%d\n",
		hw_name, (unsigned long)mem, irq);
		wiphy_info(hw->wiphy, "%s mem=0x%p, irq=%d\n",
		hw_name, mem, irq);

		return 0;

drivers/net/wireless/ath/ath9k/pci.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -988,8 +988,8 @@ static int ath_pci_probe(struct pci_dev pdev, const struct pci_device_id id)
		sc->sc_ah->msi_reg = 0;

		ath9k_hw_name(sc->sc_ah, hw_name, sizeof(hw_name));
		wiphy_info(hw->wiphy, "%s mem=0x%lx, irq=%d\n",
		hw_name, (unsigned long)sc->mem, pdev->irq);
		wiphy_info(hw->wiphy, "%s mem=0x%p, irq=%d\n",
		hw_name, sc->mem, pdev->irq);

		return 0;