Commit 06578ac6 authored Mar 01, 2023 by Justin Tee Committed by Martin K. Petersen Mar 09, 2023

scsi: lpfc: Record LOGO state with discovery engine even if aborted



A target vendor array reboot in P2P topology can sometimes result in
unsuccessful rediscovery.

Rework the lpfc_cmpl_els_logo() routine such that when the LOGO completes
as a failure because of driver abort, the LOGO state is still recorded with
the discovery state machine.

This is a small rework to set LOGO completion without forcing a device
removal state change.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20230301231626.9621-5-justintee8345@gmail.com


Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent c0d6071a

drivers/scsi/lpfc/lpfc_els.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -3037,15 +3037,16 @@ lpfc_cmpl_els_logo(struct lpfc_hba phba, struct lpfc_iocbq cmdiocb,
		ndlp->nlp_DID, ulp_status,
		ulp_word4);

		if (lpfc_error_lost_link(ulp_status, ulp_word4)) {
		if (lpfc_error_lost_link(ulp_status, ulp_word4))
		skip_recovery = 1;
		goto out;
		}
		}

		/* Call state machine. This will unregister the rpi if needed. */
		lpfc_disc_state_machine(vport, ndlp, cmdiocb, NLP_EVT_CMPL_LOGO);

		if (skip_recovery)
		goto out;

		/* The driver sets this flag for an NPIV instance that doesn't want to
		* log into the remote port.
		*/