Commit 07ebbc3a authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: aic7xxx: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-22-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 13522352

drivers/scsi/aic7xxx/aic79xx_osm.c

+1 −2
Original line number Diff line number Diff line
@@ -581,7 +581,6 @@ ahd_linux_queue_lck(struct scsi_cmnd * cmd, void (*scsi_done) (struct scsi_cmnd 


	ahd = *(struct ahd_softc **)cmd->device->host->hostdata;



	cmd->scsi_done = scsi_done;

	cmd->result = CAM_REQ_INPROG << 16;

	rtn = ahd_linux_run_command(ahd, dev, cmd);
@@ -2111,7 +2110,7 @@ ahd_linux_queue_cmd_complete(struct ahd_softc *ahd, struct scsi_cmnd *cmd) 


	ahd_cmd_set_transaction_status(cmd, new_status);



	cmd->scsi_done(cmd);

	scsi_done(cmd);

}



static void

drivers/scsi/aic7xxx/aic7xxx_osm.c

+1 −2
Original line number Diff line number Diff line
@@ -530,7 +530,6 @@ ahc_linux_queue_lck(struct scsi_cmnd * cmd, void (*scsi_done) (struct scsi_cmnd 


	ahc_lock(ahc, &flags);

	if (ahc->platform_data->qfrozen == 0) {

		cmd->scsi_done = scsi_done;

		cmd->result = CAM_REQ_INPROG << 16;

		rtn = ahc_linux_run_command(ahc, dev, cmd);

	}
@@ -1986,7 +1985,7 @@ ahc_linux_queue_cmd_complete(struct ahc_softc *ahc, struct scsi_cmnd *cmd) 
		ahc_cmd_set_transaction_status(cmd, new_status);

	}



	cmd->scsi_done(cmd);

	scsi_done(cmd);

}



static void