Commit 091f9f7f authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Bjorn Helgaas
Browse files

PCI: Change pdev->rom_attr_enabled to single bit 

Make 'rom_attr_enabled' a single bit in a bitfield and move it close to an
existing bitfield so that they can be merged.

This field is only used in 'drivers/pci/pci-sysfs.c' to store 0 or 1.

On x86_64, this shrinks the size of 'struct pci_dev' by 8 bytes from 3560
to 3552.

Link: https://lore.kernel.org/r/d7a34ad369336db73145c3efbade895e792a0ad3.1687105455.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 849846c4

include/linux/pci.h

+1 −1
Original line number Diff line number Diff line
@@ -464,12 +464,12 @@ struct pci_dev { 
	unsigned int	no_vf_scan:1;		/* Don't scan for VFs after IOV enablement */

	unsigned int	no_command_memory:1;	/* No PCI_COMMAND_MEMORY */

	unsigned int	rom_bar_overlap:1;	/* ROM BAR disable broken */

	unsigned int	rom_attr_enabled:1;	/* Display of ROM attribute enabled? */

	pci_dev_flags_t dev_flags;

	atomic_t	enable_cnt;	/* pci_enable_device has been called */



	u32		saved_config_space[16]; /* Config space saved at suspend time */

	struct hlist_head saved_cap_space;

	int		rom_attr_enabled;	/* Display of ROM attribute enabled? */

	struct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */

	struct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs file for WC mapping of resources */