Commit 0979e265 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: csiostor: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-27-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a75af82a

drivers/scsi/csiostor/csio_scsi.c

+4 −4
Original line number Diff line number Diff line
@@ -1720,7 +1720,7 @@ csio_scsi_err_handler(struct csio_hw *hw, struct csio_ioreq *req) 
	}



	cmnd->result = (((host_status) << 16) | scsi_status);

	cmnd->scsi_done(cmnd);

	scsi_done(cmnd);



	/* Wake up waiting threads */

	csio_scsi_cmnd(req) = NULL;
@@ -1748,7 +1748,7 @@ csio_scsi_cbfn(struct csio_hw *hw, struct csio_ioreq *req) 
		}



		cmnd->result = (((host_status) << 16) | scsi_status);

		cmnd->scsi_done(cmnd);

		scsi_done(cmnd);

		csio_scsi_cmnd(req) = NULL;

		CSIO_INC_STATS(csio_hw_to_scsim(hw), n_tot_success);

	} else {
@@ -1876,7 +1876,7 @@ csio_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmnd) 
	return rv;



err_done:

	cmnd->scsi_done(cmnd);

	scsi_done(cmnd);

	return 0;

}
@@ -1979,7 +1979,7 @@ csio_eh_abort_handler(struct scsi_cmnd *cmnd) 
		spin_unlock_irq(&hw->lock);



		cmnd->result = (DID_ERROR << 16);

		cmnd->scsi_done(cmnd);

		scsi_done(cmnd);



		return FAILED;

	}