Commit 0b54c2e3 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Jonathan Corbet
Browse files

scripts/kernel-doc: ignore identifier on anonymous enums 



When anonymous enums are used, the identifier is empty.

While, IMO, it should be avoided the usage of such enums,
adding support for it is not hard.

So, postpone the check for empty identifiers to happen
only at the dump phase.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/055ad57879f1b9381b90879e00f72fde1c3a5647.1614760910.git.mchehab+huawei@kernel.org


Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
parent e85d92b3

scripts/kernel-doc

+7 −2
Original line number Diff line number Diff line
@@ -1412,9 +1412,14 @@ sub dump_enum($$) { 


    if ($members) {

	if ($identifier ne $declaration_name) {

	    if ($identifier eq "") {

		print STDERR "${file}:$.: warning: wrong kernel-doc identifier on line:\n";

	    } else {

		print STDERR "${file}:$.: warning: expecting prototype for enum $identifier. Prototype was for enum $declaration_name instead\n";

	    }

	    return;

	}

	$declaration_name = "(anonymous)" if ($declaration_name eq "");



	my %_members;
@@ -2134,7 +2139,7 @@ sub process_name($$) { 
	    ++$warnings;

	}



	if ($identifier eq "") {

	if ($identifier eq "" && $decl_type ne "enum") {

	    print STDERR "${file}:$.: warning: wrong kernel-doc identifier on line:\n";

	    print STDERR $_;

	    ++$warnings;