Commit 0c31fa0e authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: storvsc_drv: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-74-bvanassche@acm.org


Reviewed-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4acf838e

drivers/scsi/storvsc_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -1154,7 +1154,7 @@ static void storvsc_command_completion(struct storvsc_cmd_request *cmd_request, 
	scsi_set_resid(scmnd,

		cmd_request->payload->range.len - data_transfer_length);



	scmnd->scsi_done(scmnd);

	scsi_done(scmnd);



	if (payload_sz >

		sizeof(struct vmbus_channel_packet_multipage_buffer))
@@ -1753,7 +1753,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) 
		 * future versions of the host.

		 */

		if (!storvsc_scsi_cmd_ok(scmnd)) {

			scmnd->scsi_done(scmnd);

			scsi_done(scmnd);

			return 0;

		}

	}