Commit 0c5dc500 authored by Guiting Shen's avatar Guiting Shen Committed by Lee Jones
Browse files

mfd: Remove redundant dev_set_drvdata() from I2C drivers



the i2c_set_clientdata() is the inline function which is complemented by
the dev_set_drvdata() internally. Do not need to use i2c_set_clientdata()
and dev_set_drvdata() at the same time.

Signed-off-by: default avatarGuiting Shen <aarongt.shen@gmail.com>
Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230425024526.6443-1-aarongt.shen@gmail.com
parent df2aac15
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -74,7 +74,6 @@ int pm80x_init(struct i2c_client *client)
	chip->irq = client->irq;

	chip->dev = &client->dev;
	dev_set_drvdata(chip->dev, chip);
	i2c_set_clientdata(chip->client, chip);

	ret = regmap_read(chip->regmap, PM80X_CHIP_ID, &val);
+0 −1
Original line number Diff line number Diff line
@@ -1166,7 +1166,6 @@ static int pm860x_probe(struct i2c_client *client)
	chip->client = client;
	i2c_set_clientdata(client, chip);
	chip->dev = &client->dev;
	dev_set_drvdata(chip->dev, chip);

	/*
	 * Both client and companion client shares same platform driver.
+0 −2
Original line number Diff line number Diff line
@@ -345,8 +345,6 @@ static int aat2870_i2c_probe(struct i2c_client *client)
		return -ENOMEM;

	aat2870->dev = &client->dev;
	dev_set_drvdata(aat2870->dev, aat2870);

	aat2870->client = client;
	i2c_set_clientdata(client, aat2870);

+0 −2
Original line number Diff line number Diff line
@@ -485,8 +485,6 @@ static int lm3533_device_init(struct lm3533 *lm3533)

	lm3533->gpio_hwen = pdata->gpio_hwen;

	dev_set_drvdata(lm3533->dev, lm3533);

	if (gpio_is_valid(lm3533->gpio_hwen)) {
		ret = devm_gpio_request_one(lm3533->dev, lm3533->gpio_hwen,
					GPIOF_OUT_INIT_LOW, "lm3533-hwen");
+0 −2
Original line number Diff line number Diff line
@@ -201,8 +201,6 @@ static int max8907_i2c_probe(struct i2c_client *i2c)
	}

	max8907->dev = &i2c->dev;
	dev_set_drvdata(max8907->dev, max8907);

	max8907->i2c_gen = i2c;
	i2c_set_clientdata(i2c, max8907);
	max8907->regmap_gen = devm_regmap_init_i2c(i2c,
Loading