Commit 0dc08e87 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: fsl-diu-fb: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent b917b0a9

drivers/video/fbdev/fsl-diu-fb.c

+2 −4
Original line number Diff line number Diff line
@@ -1823,7 +1823,7 @@ static int fsl_diu_probe(struct platform_device *pdev) 
	return ret;

}



static int fsl_diu_remove(struct platform_device *pdev)

static void fsl_diu_remove(struct platform_device *pdev)

{

	struct fsl_diu_data *data;

	int i;
@@ -1837,8 +1837,6 @@ static int fsl_diu_remove(struct platform_device *pdev) 
		uninstall_fb(&data->fsl_diu_info[i]);



	iounmap(data->diu_reg);



	return 0;

}



#ifndef MODULE
@@ -1885,7 +1883,7 @@ static struct platform_driver fsl_diu_driver = { 
		.of_match_table = fsl_diu_match,

	},

	.probe  	= fsl_diu_probe,

	.remove 	= fsl_diu_remove,

	.remove_new 	= fsl_diu_remove,

	.suspend	= fsl_diu_suspend,

	.resume		= fsl_diu_resume,

};