Commit 0fff71c5 authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: idxd: fix wq size store permission state 



WQ size can only be changed when the device is disabled. Current code
allows change when device is enabled but wq is disabled. Change the check
to detect device state.

Fixes: c52ca478 ("dmaengine: idxd: add configuration component of driver")
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/161782558755.107710.18138252584838406025.stgit@djiang5-desk3.ch.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent ea6a5735

drivers/dma/idxd/sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -989,7 +989,7 @@ static ssize_t wq_size_store(struct device *dev, 
	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))

		return -EPERM;



	if (wq->state != IDXD_WQ_DISABLED)

	if (idxd->state == IDXD_DEV_ENABLED)

		return -EPERM;



	if (size + total_claimed_wq_size(idxd) - wq->size > idxd->max_wq_size)