Commit 10b34ece authored by Daniel Axtens's avatar Daniel Axtens Committed by Michael Ellerman
Browse files

powerpc/eeh: Small refactor of eeh_handle_normal_event() 



The control flow of eeh_handle_normal_event() is a bit tricky.

Break out one of the error handling paths - rather than be in an else
block, we'll make it part of the regular body of the function and put a
'goto out;' in the true limb of the if.

Signed-off-by: default avatarDaniel Axtens <dja@axtens.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211015070628.1331635-1-dja@axtens.net
parent 1e7684dc

arch/powerpc/kernel/eeh_driver.c

+35 −34
Original line number Original line Diff line number Diff line
@@ -1054,7 +1054,9 @@ void eeh_handle_normal_event(struct eeh_pe *pe) 
		}

		}





		pr_info("EEH: Recovery successful.\n");

		pr_info("EEH: Recovery successful.\n");

	} else  {

		goto out;

	}



	/*

	/*

	 * About 90% of all real-life EEH failures in the field

	 * About 90% of all real-life EEH failures in the field

	 * are due to poorly seated PCI cards. Only 10% or so are

	 * are due to poorly seated PCI cards. Only 10% or so are
@@ -1093,7 +1095,6 @@ void eeh_handle_normal_event(struct eeh_pe *pe) 
		/* The passed PE should no longer be used */

		/* The passed PE should no longer be used */

		return;

		return;

	}

	}

	}





out:

out:

	/*

	/*