Commit 110a21fe authored by David Sterba's avatar David Sterba
Browse files

btrfs: introduce conditional wakeup helpers 



Add convenience wrappers for the waitqueue management that involves
memory barriers to prevent deadlocks. The helpers will let us remove
barriers and the necessary comments in several places.

Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ff3d27a0

fs/btrfs/ctree.h

+22 −0
Original line number Diff line number Diff line
@@ -3755,4 +3755,26 @@ static inline int btrfs_is_testing(struct btrfs_fs_info *fs_info) 
	return 0;

}



static inline void cond_wake_up(struct wait_queue_head *wq)

{

	/*

	 * This implies a full smp_mb barrier, see comments for

	 * waitqueue_active why.

	 */

	if (wq_has_sleeper(wq))

		wake_up(wq);

}



static inline void cond_wake_up_nomb(struct wait_queue_head *wq)

{

	/*

	 * Special case for conditional wakeup where the barrier required for

	 * waitqueue_active is implied by some of the preceding code. Eg. one

	 * of such atomic operations (atomic_dec_and_return, ...), or a

	 * unlock/lock sequence, etc.

	 */

	if (waitqueue_active(wq))

		wake_up(wq);

}



#endif