Commit 117bd98d authored by Yuan Can's avatar Yuan Can Committed by Florian Fainelli
Browse files

firmware: raspberrypi: Use dev_err_probe() to simplify code 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20220924025041.29389-1-yuancan@huawei.com


Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
parent 9abf2313

drivers/firmware/raspberrypi.c

+3 −6
Original line number Diff line number Diff line
@@ -268,12 +268,9 @@ static int rpi_firmware_probe(struct platform_device *pdev) 
	fw->cl.tx_block = true;



	fw->chan = mbox_request_channel(&fw->cl, 0);

	if (IS_ERR(fw->chan)) {

		int ret = PTR_ERR(fw->chan);

		if (ret != -EPROBE_DEFER)

			dev_err(dev, "Failed to get mbox channel: %d\n", ret);

		return ret;

	}

	if (IS_ERR(fw->chan))

		return dev_err_probe(dev, PTR_ERR(fw->chan),

				     "Failed to get mbox channel\n");



	init_completion(&fw->c);

	kref_init(&fw->consumers);