Commit 120bdac7 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: rtd529: usleep_range is preferred over udelay 



Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt".  `udelay()` is only used in the
firmware upload process.  Replace them with `usleep_range()` with a
reasonable upper limit.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c3aea012

drivers/staging/comedi/drivers/rtd520.c

+2 −2
Original line number Diff line number Diff line
@@ -513,7 +513,7 @@ static int rtd520_probe_fifo_depth(struct comedi_device *dev) 
		unsigned fifo_status;

		/* trigger conversion */

		writew(0, dev->mmio + LAS0_ADC);

		udelay(1);

		usleep_range(1, 1000);

		fifo_status = readl(dev->mmio + LAS0_ADC);

		if ((fifo_status & FS_ADC_HEMPTY) == 0) {

			fifo_size = 2 * i;
@@ -1142,7 +1142,7 @@ static void rtd_reset(struct comedi_device *dev) 
	struct rtd_private *devpriv = dev->private;



	writel(0, dev->mmio + LAS0_BOARD_RESET);

	udelay(100);		/* needed? */

	usleep_range(100, 1000);	/* needed? */

	writel(0, devpriv->lcfg + PLX_INTRCS_REG);

	writew(0, dev->mmio + LAS0_IT);

	writew(~0, dev->mmio + LAS0_CLEAR);