Commit 12c762e0 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: si470x: fix printk warnings with clang 



Clang doesn't like "%hu" on macros:

	drivers/media/radio/si470x/radio-si470x-i2c.c:414:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]
	drivers/media/radio/si470x/radio-si470x-i2c.c:417:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]

Besides that, changeset cbacb5ab ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
dropped recomendation of using %h.

So, just replace them with "%u".

Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 02d6276f

drivers/media/radio/si470x/radio-si470x-i2c.c

+2 −2
Original line number Diff line number Diff line
@@ -410,10 +410,10 @@ static int si470x_i2c_probe(struct i2c_client *client) 
			radio->registers[DEVICEID], radio->registers[SI_CHIPID]);

	if ((radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE) < RADIO_FW_VERSION) {

		dev_warn(&client->dev,

			"This driver is known to work with firmware version %hu,\n",

			"This driver is known to work with firmware version %u,\n",

			RADIO_FW_VERSION);

		dev_warn(&client->dev,

			"but the device has firmware version %hu.\n",

			"but the device has firmware version %u.\n",

			radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE);

		version_warning = 1;

	}

drivers/media/radio/si470x/radio-si470x-usb.c

+4 −4
Original line number Diff line number Diff line
@@ -681,10 +681,10 @@ static int si470x_usb_driver_probe(struct usb_interface *intf, 
			radio->registers[DEVICEID], radio->registers[SI_CHIPID]);

	if ((radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE) < RADIO_FW_VERSION) {

		dev_warn(&intf->dev,

			"This driver is known to work with firmware version %hu,\n",

			"This driver is known to work with firmware version %u,\n",

			RADIO_FW_VERSION);

		dev_warn(&intf->dev,

			"but the device has firmware version %hu.\n",

			"but the device has firmware version %u.\n",

			radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE);

		version_warning = 1;

	}
@@ -698,10 +698,10 @@ static int si470x_usb_driver_probe(struct usb_interface *intf, 
			radio->software_version, radio->hardware_version);

	if (radio->hardware_version < RADIO_HW_VERSION) {

		dev_warn(&intf->dev,

			"This driver is known to work with hardware version %hu,\n",

			"This driver is known to work with hardware version %u,\n",

			RADIO_HW_VERSION);

		dev_warn(&intf->dev,

			"but the device has hardware version %hu.\n",

			"but the device has hardware version %u.\n",

			radio->hardware_version);

		version_warning = 1;

	}