Commit 13cd9ac6 authored Mar 19, 2023 by Uwe Kleine-König Committed by Rob Herring Mar 20, 2023

of: unittest: Drop if blocks with always false condition



unittest_gpio_remove() is only called after unittest_gpio_probe() completed
successfully. In this case driver data was set to a non-NULL value and so
platform_get_drvdata() never returns NULL.

Also note that the compiler might optimize away this check anyhow as
devptr was already dereferenced for the dev_dbg call above.

Drop this if block.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230319100620.295849-3-u.kleine-koenig@pengutronix.de


Signed-off-by: Rob Herring <robh@kernel.org>

parent 5cdade2d

drivers/of/unittest.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1633,9 +1633,6 @@ static int unittest_gpio_remove(struct platform_device *pdev)

		dev_dbg(dev, "%s for node @%pfw\n", __func__, devptr->chip.fwnode);

		if (!devptr)
		return -EINVAL;

		if (devptr->chip.base != -1)
		gpiochip_remove(&devptr->chip);