Commit 14212fe7 authored by Bernard Zhao's avatar Bernard Zhao Committed by Sam Ravnborg
Browse files

drm/via: reduce no need mutex_lock area 



In function via_mem_alloc`s error branch, DRM_ERROR is protected
in the mutex_lock(&dev->struct_mutex) area.
>From the code, we see that DRM_ERROR is just an error log print
without any struct element, there is no need to protect this.

Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200814083021.8962-1-bernard@vivo.com
parent 77bb5aaf

drivers/gpu/drm/via/via_mm.c

+1 −1
Original line number Diff line number Diff line
@@ -129,9 +129,9 @@ int via_mem_alloc(struct drm_device *dev, void *data, 
	mutex_lock(&dev->struct_mutex);

	if (0 == ((mem->type == VIA_MEM_VIDEO) ? dev_priv->vram_initialized :

		      dev_priv->agp_initialized)) {

		mutex_unlock(&dev->struct_mutex);

		DRM_ERROR

		    ("Attempt to allocate from uninitialized memory manager.\n");

		mutex_unlock(&dev->struct_mutex);

		return -EINVAL;

	}