Commit 157edcca authored by Chaehyun Lim's avatar Chaehyun Lim Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: handle_set_mac_address: change return type to void 



When handle_set_mac_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes a brace of if statement due to
have a single statement.

Signed-off-by: default avatarChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 31cc9885

drivers/staging/wilc1000/host_interface.c

+4 −7
Original line number Diff line number Diff line
@@ -424,7 +424,7 @@ static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx) 
	return result;

}



static s32 handle_set_mac_address(struct wilc_vif *vif,

static void handle_set_mac_address(struct wilc_vif *vif,

				   struct set_mac_addr *set_mac_addr)

{

	s32 result = 0;
@@ -432,7 +432,7 @@ static s32 handle_set_mac_address(struct wilc_vif *vif, 


	u8 *mac_buf = kmemdup(set_mac_addr->mac_addr, ETH_ALEN, GFP_KERNEL);

	if (!mac_buf)

		return -ENOMEM;

		return;



	wid.id = (u16)WID_MAC_ADDR;

	wid.type = WID_STR;
@@ -441,13 +441,10 @@ static s32 handle_set_mac_address(struct wilc_vif *vif, 


	result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,

				      wilc_get_vif_idx(vif));

	if (result) {

	if (result)

		PRINT_ER("Failed to set mac address\n");

		result = -EFAULT;

	}



	kfree(mac_buf);

	return result;

}



static s32 handle_get_mac_address(struct wilc_vif *vif,