Commit 163bfb0c authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Linus Walleij
Browse files

pinctrl: qcom: lpass-lpi: set output value before enabling output 



As per Hardware Programming Guide, when configuring pin as output,
set the pin value before setting output-enable (OE).  Similar approach
is in main SoC TLMM pin controller.

Cc: <stable@vger.kernel.org>
Fixes: 6e261d10 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230309154949.658380-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 29f6e7e3

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c

+9 −5
Original line number Diff line number Diff line
@@ -221,6 +221,15 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, 
		}

	}



	/*

	 * As per Hardware Programming Guide, when configuring pin as output,

	 * set the pin value before setting output-enable (OE).

	 */

	if (output_enabled) {

		val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);

		lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val);

	}



	val = lpi_gpio_read(pctrl, group, LPI_GPIO_CFG_REG);



	u32p_replace_bits(&val, pullup, LPI_GPIO_PULL_MASK);
@@ -230,11 +239,6 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, 


	lpi_gpio_write(pctrl, group, LPI_GPIO_CFG_REG, val);



	if (output_enabled) {

		val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);

		lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val);

	}



	return 0;

}