Commit 16f84d63 authored by Marco Cesati's avatar Marco Cesati Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove typedefs in HalPwrSeqCmd.h 



This commit fixes the following checkpatch.pl warnings:

    WARNING: do not add new typedefs
    #85: FILE: include/HalPwrSeqCmd.h:85:
    +typedef enum _PWRSEQ_CMD_DELAY_UNIT_ {

    WARNING: do not add new typedefs
    #90: FILE: include/HalPwrSeqCmd.h:90:
    +typedef struct _WL_PWR_CFG_ {

Signed-off-by: default avatarMarco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210312082638.25512-25-marco.cesati@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d44d0312

drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c

+2 −2
Original line number Diff line number Diff line
@@ -39,10 +39,10 @@ u8 HalPwrSeqCmdParsing( 
	u8 CutVersion,

	u8 FabVersion,

	u8 InterfaceType,

	WLAN_PWR_CFG PwrSeqCmd[]

	struct WLAN_PWR_CFG PwrSeqCmd[]

)

{

	WLAN_PWR_CFG PwrCfgCmd;

	struct WLAN_PWR_CFG PwrCfgCmd;

	u8 bPollingBit = false;

	u32 AryIdx = 0;

	u8 value = 0;

drivers/staging/rtl8723bs/hal/hal_pwr_seq.c

+11 −11
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ Major Change History: 


/* drivers should parse below arrays and do the corresponding actions */

/* 3 Power on  Array */

WLAN_PWR_CFG rtl8723B_power_on_flow[

struct WLAN_PWR_CFG rtl8723B_power_on_flow[

	RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS+

	RTL8723B_TRANS_END_STEPS

] = {
@@ -30,7 +30,7 @@ WLAN_PWR_CFG rtl8723B_power_on_flow[ 
};



/* 3Radio off GPIO Array */

WLAN_PWR_CFG rtl8723B_radio_off_flow[

struct WLAN_PWR_CFG rtl8723B_radio_off_flow[

	RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+

	RTL8723B_TRANS_END_STEPS

] = {
@@ -39,7 +39,7 @@ WLAN_PWR_CFG rtl8723B_radio_off_flow[ 
};



/* 3Card Disable Array */

WLAN_PWR_CFG rtl8723B_card_disable_flow[

struct WLAN_PWR_CFG rtl8723B_card_disable_flow[

	RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+

	RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+

	RTL8723B_TRANS_END_STEPS
@@ -50,7 +50,7 @@ WLAN_PWR_CFG rtl8723B_card_disable_flow[ 
};



/* 3 Card Enable Array */

WLAN_PWR_CFG rtl8723B_card_enable_flow[

struct WLAN_PWR_CFG rtl8723B_card_enable_flow[

	RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+

	RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+

	RTL8723B_TRANS_END_STEPS
@@ -61,7 +61,7 @@ WLAN_PWR_CFG rtl8723B_card_enable_flow[ 
};



/* 3Suspend Array */

WLAN_PWR_CFG rtl8723B_suspend_flow[

struct WLAN_PWR_CFG rtl8723B_suspend_flow[

	RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+

	RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+

	RTL8723B_TRANS_END_STEPS
@@ -72,7 +72,7 @@ WLAN_PWR_CFG rtl8723B_suspend_flow[ 
};



/* 3 Resume Array */

WLAN_PWR_CFG rtl8723B_resume_flow[

struct WLAN_PWR_CFG rtl8723B_resume_flow[

	RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+

	RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+

	RTL8723B_TRANS_END_STEPS
@@ -83,7 +83,7 @@ WLAN_PWR_CFG rtl8723B_resume_flow[ 
};



/* 3HWPDN Array */

WLAN_PWR_CFG rtl8723B_hwpdn_flow[

struct WLAN_PWR_CFG rtl8723B_hwpdn_flow[

	RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+

	RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+

	RTL8723B_TRANS_END_STEPS
@@ -94,7 +94,7 @@ WLAN_PWR_CFG rtl8723B_hwpdn_flow[ 
};



/* 3 Enter LPS */

WLAN_PWR_CFG rtl8723B_enter_lps_flow[

struct WLAN_PWR_CFG rtl8723B_enter_lps_flow[

	RTL8723B_TRANS_ACT_TO_LPS_STEPS+RTL8723B_TRANS_END_STEPS

] = {

	/* FW behavior */
@@ -103,7 +103,7 @@ WLAN_PWR_CFG rtl8723B_enter_lps_flow[ 
};



/* 3 Leave LPS */

WLAN_PWR_CFG rtl8723B_leave_lps_flow[

struct WLAN_PWR_CFG rtl8723B_leave_lps_flow[

	RTL8723B_TRANS_LPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS

] = {

	/* FW behavior */
@@ -112,7 +112,7 @@ WLAN_PWR_CFG rtl8723B_leave_lps_flow[ 
};



/* 3 Enter SW LPS */

WLAN_PWR_CFG rtl8723B_enter_swlps_flow[

struct WLAN_PWR_CFG rtl8723B_enter_swlps_flow[

	RTL8723B_TRANS_ACT_TO_SWLPS_STEPS+RTL8723B_TRANS_END_STEPS

] = {

	/* SW behavior */
@@ -121,7 +121,7 @@ WLAN_PWR_CFG rtl8723B_enter_swlps_flow[ 
};



/* 3 Leave SW LPS */

WLAN_PWR_CFG rtl8723B_leave_swlps_flow[

struct WLAN_PWR_CFG rtl8723B_leave_swlps_flow[

	RTL8723B_TRANS_SWLPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS

] = {

	/* SW behavior */

drivers/staging/rtl8723bs/include/HalPwrSeqCmd.h

+5 −5
Original line number Diff line number Diff line
@@ -82,12 +82,12 @@ 
#define	PWR_CUT_ALL_MSK			0xFF





typedef enum _PWRSEQ_CMD_DELAY_UNIT_ {

enum PWRSEQ_CMD_DELAY_UNIT {

	PWRSEQ_DELAY_US,

	PWRSEQ_DELAY_MS,

} PWRSEQ_DELAY_UNIT;

};



typedef struct _WL_PWR_CFG_ {

struct WLAN_PWR_CFG {

	u16 offset;

	u8 cut_msk;

	u8 fab_msk:4;
@@ -96,7 +96,7 @@ typedef struct _WL_PWR_CFG_ { 
	u8 cmd:4;

	u8 msk;

	u8 value;

} WLAN_PWR_CFG, *PWLAN_PWR_CFG;

};





#define GET_PWR_CFG_OFFSET(__PWR_CMD)		__PWR_CMD.offset
@@ -117,6 +117,6 @@ u8 HalPwrSeqCmdParsing( 
	u8 		CutVersion,

	u8 		FabVersion,

	u8 		InterfaceType,

	WLAN_PWR_CFG	PwrCfgCmd[]);

	struct WLAN_PWR_CFG	PwrCfgCmd[]);



#endif

drivers/staging/rtl8723bs/include/hal_pwr_seq.h

+11 −11
Original line number Diff line number Diff line
@@ -219,15 +219,15 @@ 
	{0xFFFF, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, 0, PWR_CMD_END, 0, 0}, 





extern WLAN_PWR_CFG rtl8723B_power_on_flow[RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_radio_off_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_card_disable_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_card_enable_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_suspend_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_resume_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_hwpdn_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_enter_lps_flow[RTL8723B_TRANS_ACT_TO_LPS_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_leave_lps_flow[RTL8723B_TRANS_LPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_enter_swlps_flow[RTL8723B_TRANS_ACT_TO_SWLPS_STEPS+RTL8723B_TRANS_END_STEPS];

extern WLAN_PWR_CFG rtl8723B_leave_swlps_flow[RTL8723B_TRANS_SWLPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_power_on_flow[RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_radio_off_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_card_disable_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_card_enable_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_suspend_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_resume_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_hwpdn_flow[RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_enter_lps_flow[RTL8723B_TRANS_ACT_TO_LPS_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_leave_lps_flow[RTL8723B_TRANS_LPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_enter_swlps_flow[RTL8723B_TRANS_ACT_TO_SWLPS_STEPS+RTL8723B_TRANS_END_STEPS];

extern struct WLAN_PWR_CFG rtl8723B_leave_swlps_flow[RTL8723B_TRANS_SWLPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];

#endif