Commit 17302d36 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp: drop superfluous comments 



Drop some unnecessary or incorrect comments.

Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221012081241.18273-3-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 28d74fc3

drivers/phy/qualcomm/phy-qcom-qmp-combo.c

+0 −4
Original line number Diff line number Diff line
@@ -1949,7 +1949,6 @@ static int qmp_combo_com_init(struct qmp_phy *qphy) 
		return 0;

	}



	/* turn on regulator supplies */

	ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);

	if (ret) {

		dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -2779,7 +2778,6 @@ static int qmp_combo_probe(struct platform_device *pdev) 
	qmp->dev = dev;

	dev_set_drvdata(dev, qmp);



	/* Get the specific init parameters of QMP phy */

	combo_cfg = of_device_get_match_data(dev);

	if (!combo_cfg)

		return -EINVAL;
@@ -2787,7 +2785,6 @@ static int qmp_combo_probe(struct platform_device *pdev) 
	usb_cfg = combo_cfg->usb_cfg;

	cfg = usb_cfg; /* Setup clks and regulators */



	/* per PHY serdes; usually located at base address */

	usb_serdes = serdes = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(serdes))

		return PTR_ERR(serdes);
@@ -2796,7 +2793,6 @@ static int qmp_combo_probe(struct platform_device *pdev) 
	if (IS_ERR(qmp->dp_com))

		return PTR_ERR(qmp->dp_com);



	/* Only two serdes for combo PHY */

	dp_serdes = devm_platform_ioremap_resource(pdev, 2);

	if (IS_ERR(dp_serdes))

		return PTR_ERR(dp_serdes);

drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c

+0 −3
Original line number Diff line number Diff line
@@ -420,7 +420,6 @@ static int qmp_pcie_msm8996_com_init(struct qmp_phy *qphy) 
		return 0;

	}



	/* turn on regulator supplies */

	ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);

	if (ret) {

		dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -845,12 +844,10 @@ static int qmp_pcie_msm8996_probe(struct platform_device *pdev) 
	qmp->dev = dev;

	dev_set_drvdata(dev, qmp);



	/* Get the specific init parameters of QMP phy */

	cfg = of_device_get_match_data(dev);

	if (!cfg)

		return -EINVAL;



	/* per PHY serdes; usually located at base address */

	serdes = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(serdes))

		return PTR_ERR(serdes);

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c

+0 −3
Original line number Diff line number Diff line
@@ -1978,7 +1978,6 @@ static int qmp_pcie_init(struct phy *phy) 
	const struct qmp_phy_cfg *cfg = qphy->cfg;

	int ret;



	/* turn on regulator supplies */

	ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);

	if (ret) {

		dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -2425,12 +2424,10 @@ static int qmp_pcie_probe(struct platform_device *pdev) 
	qmp->dev = dev;

	dev_set_drvdata(dev, qmp);



	/* Get the specific init parameters of QMP phy */

	cfg = of_device_get_match_data(dev);

	if (!cfg)

		return -EINVAL;



	/* per PHY serdes; usually located at base address */

	serdes = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(serdes))

		return PTR_ERR(serdes);

drivers/phy/qualcomm/phy-qcom-qmp-ufs.c

+0 −3
Original line number Diff line number Diff line
@@ -849,7 +849,6 @@ static int qmp_ufs_com_init(struct qmp_phy *qphy) 
	void __iomem *pcs = qphy->pcs;

	int ret;



	/* turn on regulator supplies */

	ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);

	if (ret) {

		dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -1194,12 +1193,10 @@ static int qmp_ufs_probe(struct platform_device *pdev) 
	qmp->dev = dev;

	dev_set_drvdata(dev, qmp);



	/* Get the specific init parameters of QMP phy */

	cfg = of_device_get_match_data(dev);

	if (!cfg)

		return -EINVAL;



	/* per PHY serdes; usually located at base address */

	serdes = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(serdes))

		return PTR_ERR(serdes);

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

+0 −5
Original line number Diff line number Diff line
@@ -2120,7 +2120,6 @@ static int qmp_usb_init(struct phy *phy) 
	void __iomem *dp_com = qmp->dp_com;

	int ret;



	/* turn on regulator supplies */

	ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);

	if (ret) {

		dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -2229,7 +2228,6 @@ static int qmp_usb_power_on(struct phy *phy) 
					cfg->rx_tbl, cfg->rx_tbl_num, 2);

	}



	/* Configure link rate, swing, etc. */

	qmp_usb_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);



	if (cfg->has_pwrdn_delay)
@@ -2719,17 +2717,14 @@ static int qmp_usb_probe(struct platform_device *pdev) 
	qmp->dev = dev;

	dev_set_drvdata(dev, qmp);



	/* Get the specific init parameters of QMP phy */

	cfg = of_device_get_match_data(dev);

	if (!cfg)

		return -EINVAL;



	/* per PHY serdes; usually located at base address */

	serdes = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(serdes))

		return PTR_ERR(serdes);



	/* per PHY dp_com; if PHY has dp_com control block */

	if (cfg->has_phy_dp_com_ctrl) {

		qmp->dp_com = devm_platform_ioremap_resource(pdev, 1);

		if (IS_ERR(qmp->dp_com))