Commit 17ad4662 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Santosh Shilimkar
Browse files

soc: ti: pm33xx: Fix some resource leak in the error handling paths of the probe function 



'am33xx_pm_rtc_setup()' allocates some resources that must be freed on the
error. Commit 2152fbbd ("soc: ti: pm33xx: Simplify RTC usage to prepare
to drop platform data") has introduced the use of these resources but has
only updated the remove function.

Fix the error handling path of the probe function now.

Fixes: 2152fbbd ("soc: ti: pm33xx: Simplify RTC usage to prepare to drop platform data")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
parent a88f66d4

drivers/soc/ti/pm33xx.c

+4 −1
Original line number Diff line number Diff line
@@ -535,7 +535,7 @@ static int am33xx_pm_probe(struct platform_device *pdev) 


	ret = am33xx_push_sram_idle();

	if (ret)

		goto err_free_sram;

		goto err_unsetup_rtc;



	am33xx_pm_set_ipc_ops();
@@ -575,6 +575,9 @@ static int am33xx_pm_probe(struct platform_device *pdev) 
err_pm_runtime_disable:

	pm_runtime_disable(dev);

	wkup_m3_ipc_put(m3_ipc);

err_unsetup_rtc:

	iounmap(rtc_base_virt);

	clk_put(rtc_fck);

err_free_sram:

	am33xx_pm_free_sram();

	pm33xx_dev = NULL;