Commit 17eee264 authored by Shang XiaoJing's avatar Shang XiaoJing Committed by Vinod Koul
Browse files

phy: usb: sunplus: Fix potential null-ptr-deref in sp_usb_phy_probe() 



sp_usb_phy_probe() will call platform_get_resource_byname() that may fail
and return NULL. devm_ioremap() will use usbphy->moon4_res_mem->start as
input, which may causes null-ptr-deref. Check the ret value of
platform_get_resource_byname() to avoid the null-ptr-deref.

Fixes: 99d9ccd9 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: default avatarShang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20221125021222.25687-1-shangxiaojing@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7124c938

drivers/phy/sunplus/phy-sunplus-usb2.c

+3 −0
Original line number Diff line number Diff line
@@ -254,6 +254,9 @@ static int sp_usb_phy_probe(struct platform_device *pdev) 
		return PTR_ERR(usbphy->phy_regs);



	usbphy->moon4_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "moon4");

	if (!usbphy->moon4_res_mem)

		return -EINVAL;



	usbphy->moon4_regs = devm_ioremap(&pdev->dev, usbphy->moon4_res_mem->start,

					  resource_size(usbphy->moon4_res_mem));

	if (!usbphy->moon4_regs)