Commit 18a95d36 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: rockchip: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent e7fa6e84

drivers/pwm/pwm-rockchip.c

+2 −4
Original line number Diff line number Diff line
@@ -376,7 +376,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev) 
	return ret;

}



static int rockchip_pwm_remove(struct platform_device *pdev)

static void rockchip_pwm_remove(struct platform_device *pdev)

{

	struct rockchip_pwm_chip *pc = platform_get_drvdata(pdev);
@@ -384,8 +384,6 @@ static int rockchip_pwm_remove(struct platform_device *pdev) 


	clk_unprepare(pc->pclk);

	clk_unprepare(pc->clk);



	return 0;

}



static struct platform_driver rockchip_pwm_driver = {
@@ -394,7 +392,7 @@ static struct platform_driver rockchip_pwm_driver = { 
		.of_match_table = rockchip_pwm_dt_ids,

	},

	.probe = rockchip_pwm_probe,

	.remove = rockchip_pwm_remove,

	.remove_new = rockchip_pwm_remove,

};

module_platform_driver(rockchip_pwm_driver);