Commit 19073450 authored by Kaixu Xia's avatar Kaixu Xia Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: make atomisp_css_stop() void 

The return value of atomisp_css_stop() function is always 0 and there
are no callers check the return value, so there's no reason for a return
value. Convert atomisp_css_stop() to a void function.

Link: https://lore.kernel.org/linux-media/1605359976-11254-1-git-send-email-kaixuxia@tencent.com


Reported-by: default avatarTosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: default avatarKaixu Xia <kaixuxia@tencent.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 3aa059ae

drivers/staging/media/atomisp/pci/atomisp_compat.h

+2 −2
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ int atomisp_css_input_configure_port(struct atomisp_sub_device *asd, 
void atomisp_create_pipes_stream(struct atomisp_sub_device *asd);

void atomisp_destroy_pipes_stream_force(struct atomisp_sub_device *asd);



int atomisp_css_stop(struct atomisp_sub_device *asd,

void atomisp_css_stop(struct atomisp_sub_device *asd,

		      enum ia_css_pipe_id pipe_id, bool in_reset);



int atomisp_css_continuous_set_num_raw_frames(

drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

+2 −3
Original line number Diff line number Diff line
@@ -2098,7 +2098,7 @@ int atomisp_css_input_configure_port( 
	return 0;

}



int atomisp_css_stop(struct atomisp_sub_device *asd,

void atomisp_css_stop(struct atomisp_sub_device *asd,

		      enum ia_css_pipe_id pipe_id, bool in_reset)

{

	struct atomisp_device *isp = asd->isp;
@@ -2188,7 +2188,6 @@ int atomisp_css_stop(struct atomisp_sub_device *asd, 
	atomisp_flush_params_queue(&asd->video_out_video_capture);

	atomisp_free_css_parameters(&asd->params.css_param);

	memset(&asd->params.css_param, 0, sizeof(asd->params.css_param));

	return 0;

}



int atomisp_css_continuous_set_num_raw_frames(

drivers/staging/media/atomisp/pci/atomisp_ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -2013,7 +2013,7 @@ int __atomisp_streamoff(struct file *file, void *fh, enum v4l2_buf_type type) 
	}

	if (first_streamoff) {

		css_pipe_id = atomisp_get_css_pipe_id(asd);

		ret = atomisp_css_stop(asd, css_pipe_id, false);

		atomisp_css_stop(asd, css_pipe_id, false);

	}

	/* cancel work queue*/

	if (asd->video_out_capture.users) {