Commit 190de754 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf c2c: Use zfree() to reduce chances of use after free 



Do defensive programming by using zfree() to initialize freed pointers
to NULL, so that eventual use after free result in a NULL pointer deref
instead of more subtle behaviour.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 9997d5dd

tools/perf/builtin-c2c.c

+7 −7
Original line number Diff line number Diff line
@@ -165,8 +165,8 @@ static void *c2c_he_zalloc(size_t size) 
	return &c2c_he->he;



out_free:

	free(c2c_he->nodeset);

	free(c2c_he->cpuset);

	zfree(&c2c_he->nodeset);

	zfree(&c2c_he->cpuset);

	free(c2c_he);

	return NULL;

}
@@ -178,13 +178,13 @@ static void c2c_he_free(void *he) 
	c2c_he = container_of(he, struct c2c_hist_entry, he);

	if (c2c_he->hists) {

		hists__delete_entries(&c2c_he->hists->hists);

		free(c2c_he->hists);

		zfree(&c2c_he->hists);

	}



	free(c2c_he->cpuset);

	free(c2c_he->nodeset);

	free(c2c_he->nodestr);

	free(c2c_he->node_stats);

	zfree(&c2c_he->cpuset);

	zfree(&c2c_he->nodeset);

	zfree(&c2c_he->nodestr);

	zfree(&c2c_he->node_stats);

	free(c2c_he);

}