Commit 19744ada authored by Lee Jones's avatar Lee Jones Committed by Alex Deucher
Browse files

drm/amd/pm/powerplay/hwmgr/vega20_thermal: Fix some outdated function documentation 



Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:217: warning: Function parameter or member 'hwmgr' not described in 'vega20_thermal_get_temperature'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:242: warning: Function parameter or member 'hwmgr' not described in 'vega20_thermal_set_temperature_range'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:242: warning: Function parameter or member 'range' not described in 'vega20_thermal_set_temperature_range'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:278: warning: Function parameter or member 'hwmgr' not described in 'vega20_thermal_enable_alert'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:296: warning: Function parameter or member 'hwmgr' not described in 'vega20_thermal_disable_alert'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:310: warning: Function parameter or member 'hwmgr' not described in 'vega20_thermal_stop_thermal_controller'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:326: warning: Function parameter or member 'hwmgr' not described in 'vega20_thermal_setup_fan_table'

Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d3c648ec

drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c

+24 −30
Original line number Diff line number Diff line
@@ -209,9 +209,9 @@ int vega20_fan_ctrl_set_fan_speed_rpm(struct pp_hwmgr *hwmgr, uint32_t speed) 
}



/**

* Reads the remote temperature from the SIslands thermal controller.

 * vega20_thermal_get_temperature - Reads the remote temperature from the SIslands thermal controller.

 *

* @param    hwmgr The address of the hardware manager.

 * @hwmgr: The address of the hardware manager.

 */

int vega20_thermal_get_temperature(struct pp_hwmgr *hwmgr)

{
@@ -230,12 +230,11 @@ int vega20_thermal_get_temperature(struct pp_hwmgr *hwmgr) 
}



/**

* Set the requested temperature range for high and low alert signals

 * vega20_thermal_set_temperature_range - Set the requested temperature range for high and low alert signals

 *

* @param    hwmgr The address of the hardware manager.

* @param    range Temperature range to be programmed for

*           high and low alert signals

* @exception PP_Result_BadInput if the input data is not valid.

 * @hwmgr: The address of the hardware manager.

 * @range: Temperature range to be programmed for high and low alert signals

 * Exception: PP_Result_BadInput if the input data is not valid.

 */

static int vega20_thermal_set_temperature_range(struct pp_hwmgr *hwmgr,

		struct PP_TemperatureRange *range)
@@ -270,9 +269,9 @@ static int vega20_thermal_set_temperature_range(struct pp_hwmgr *hwmgr, 
}



/**

* Enable thermal alerts on the RV770 thermal controller.

 * vega20_thermal_enable_alert - Enable thermal alerts on the RV770 thermal controller.

 *

* @param    hwmgr The address of the hardware manager.

 * @hwmgr: The address of the hardware manager.

 */

static int vega20_thermal_enable_alert(struct pp_hwmgr *hwmgr)

{
@@ -289,8 +288,8 @@ static int vega20_thermal_enable_alert(struct pp_hwmgr *hwmgr) 
}



/**

* Disable thermal alerts on the RV770 thermal controller.

* @param    hwmgr The address of the hardware manager.

 * vega20_thermal_disable_alert - Disable thermal alerts on the RV770 thermal controller.

 * @hwmgr: The address of the hardware manager.

 */

int vega20_thermal_disable_alert(struct pp_hwmgr *hwmgr)

{
@@ -302,9 +301,9 @@ int vega20_thermal_disable_alert(struct pp_hwmgr *hwmgr) 
}



/**

* Uninitialize the thermal controller.

 * vega20_thermal_stop_thermal_controller - Uninitialize the thermal controller.

 * Currently just disables alerts.

* @param    hwmgr The address of the hardware manager.

 * @hwmgr: The address of the hardware manager.

 */

int vega20_thermal_stop_thermal_controller(struct pp_hwmgr *hwmgr)

{
@@ -314,13 +313,8 @@ int vega20_thermal_stop_thermal_controller(struct pp_hwmgr *hwmgr) 
}



/**

* Set up the fan table to control the fan using the SMC.

* @param    hwmgr  the address of the powerplay hardware manager.

* @param    pInput the pointer to input data

* @param    pOutput the pointer to output data

* @param    pStorage the pointer to temporary storage

* @param    Result the last failure code

* @return   result from set temperature range routine

 * vega20_thermal_setup_fan_table - Set up the fan table to control the fan using the SMC.

 * @hwmgr:  the address of the powerplay hardware manager.

 */

static int vega20_thermal_setup_fan_table(struct pp_hwmgr *hwmgr)

{