Commit 199a0cc0 authored by Liang Zhen's avatar Liang Zhen Committed by Greg Kroah-Hartman
Browse files

staging/lustre/o2iblnd: leak cmid in kiblnd_dev_need_failover 



cmid created by kiblnd_dev_need_failover should always be destroyed,
however it is not the case in current implementation and we will leak
cmid when this function detected a device failover.

Signed-off-by: default avatarLiang Zhen <liang.zhen@intel.com>
Reviewed-on: http://review.whamcloud.com/14603
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6480


Reviewed-by: default avatarIsaac Huang <he.huang@intel.com>
Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aefd9d71

drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c

+3 −6
Original line number Diff line number Diff line
@@ -2228,13 +2228,10 @@ static int kiblnd_dev_need_failover(kib_dev_t *dev) 
		return rc;

	}



	if (dev->ibd_hdev->ibh_ibdev == cmid->device) {

		/* don't need device failover */

	rc = dev->ibd_hdev->ibh_ibdev != cmid->device; /* true for failover */

	rdma_destroy_id(cmid);

		return 0;

	}



	return 1;

	return rc;

}



int kiblnd_dev_failover(kib_dev_t *dev)