Commit 1a2433b0 authored by Arthur Simchaev's avatar Arthur Simchaev Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Remove redundant function definitions from ufshcd.h 

Remove Query-Request API function declarations from include/ufs/ufshcd.h
and move them to the ufs core private header.

Link: https://lore.kernel.org/r/1663761485-2532-1-git-send-email-Arthur.Simchaev@wdc.com


Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarArthur Simchaev <Arthur.Simchaev@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3d217b9a

drivers/ufs/core/ufshcd-priv.h

+5 −0
Original line number Diff line number Diff line
@@ -42,6 +42,11 @@ static inline void ufs_hwmon_remove(struct ufs_hba *hba) {} 
static inline void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask) {}

#endif



int ufshcd_query_descriptor_retry(struct ufs_hba *hba,

				  enum query_opcode opcode,

				  enum desc_idn idn, u8 index,

				  u8 selector,

				  u8 *desc_buf, int *buf_len);

int ufshcd_read_desc_param(struct ufs_hba *hba,

			   enum desc_idn desc_id,

			   int desc_index,

include/ufs/ufshcd.h

+0 −20
Original line number Diff line number Diff line
@@ -1175,26 +1175,6 @@ static inline int ufshcd_disable_host_tx_lcc(struct ufs_hba *hba) 
	return ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);

}



/* Expose Query-Request API */

int ufshcd_query_descriptor_retry(struct ufs_hba *hba,

				  enum query_opcode opcode,

				  enum desc_idn idn, u8 index,

				  u8 selector,

				  u8 *desc_buf, int *buf_len);

int ufshcd_read_desc_param(struct ufs_hba *hba,

			   enum desc_idn desc_id,

			   int desc_index,

			   u8 param_offset,

			   u8 *param_read_buf,

			   u8 param_size);

int ufshcd_query_attr_retry(struct ufs_hba *hba, enum query_opcode opcode,

			    enum attr_idn idn, u8 index, u8 selector,

			    u32 *attr_val);

int ufshcd_query_attr(struct ufs_hba *hba, enum query_opcode opcode,

		      enum attr_idn idn, u8 index, u8 selector, u32 *attr_val);

int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,

	enum flag_idn idn, u8 index, bool *flag_res);



void ufshcd_auto_hibern8_enable(struct ufs_hba *hba);

void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit);

void ufshcd_fixup_dev_quirks(struct ufs_hba *hba,