Commit 1a3b704d authored by Lv Ruyi's avatar Lv Ruyi Committed by Mauro Carvalho Chehab
Browse files

media: amphion: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarLv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 37ed01d5

drivers/media/platform/amphion/vpu_dbg.c

+0 −12
Original line number Diff line number Diff line
@@ -413,10 +413,6 @@ int vpu_inst_create_dbgfs_file(struct vpu_inst *inst) 
					    vpu->debugfs,

					    inst,

					    &vpu_dbg_inst_fops);

	if (!inst->debugfs) {

		dev_err(inst->dev, "vpu create debugfs %s fail\n", name);

		return -EINVAL;

	}



	return 0;

}
@@ -451,10 +447,6 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core) 
						    vpu->debugfs,

						    core,

						    &vpu_dbg_core_fops);

		if (!core->debugfs) {

			dev_err(core->dev, "vpu create debugfs %s fail\n", name);

			return -EINVAL;

		}

	}

	if (!core->debugfs_fwlog) {

		scnprintf(name, sizeof(name), "fwlog.%d", core->id);
@@ -463,10 +455,6 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core) 
							  vpu->debugfs,

							  core,

							  &vpu_dbg_fwlog_fops);

		if (!core->debugfs_fwlog) {

			dev_err(core->dev, "vpu create debugfs %s fail\n", name);

			return -EINVAL;

		}

	}



	return 0;