Commit 1ce8c48b authored by Jonathan Marek's avatar Jonathan Marek Committed by Mauro Carvalho Chehab
Browse files

media: camss: vfe-170: fix "VFE halt timeout" error 



This function waits for halt_complete but doesn't do anything to cause
it to complete, and always hits the "VFE halt timeout" error. Just delete
this code for now.

Fixes: 7319cdf1 ("media: camss: Add support for VFE hardware version Titan 170")
Signed-off-by: default avatarJonathan Marek <jonathan@marek.ca>
Reviewed-by: default avatarRobert Foss <robert.foss@linaro.org>
Tested-by: default avatarJulian Grahsl <jgrahsl@snap.com>
Tested-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent ed38a146

drivers/media/platform/qcom/camss/camss-vfe-170.c

+1 −11
Original line number Diff line number Diff line
@@ -395,17 +395,7 @@ static irqreturn_t vfe_isr(int irq, void *dev) 
 */

static int vfe_halt(struct vfe_device *vfe)

{

	unsigned long time;



	reinit_completion(&vfe->halt_complete);



	time = wait_for_completion_timeout(&vfe->halt_complete,

					   msecs_to_jiffies(VFE_HALT_TIMEOUT_MS));

	if (!time) {

		dev_err(vfe->camss->dev, "VFE halt timeout\n");

		return -EIO;

	}



	/* rely on vfe_disable_output() to stop the VFE */

	return 0;

}