Commit 1daea8ed authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Simon Horman
Browse files

ipvs: Hoist computation of ipvs earlier in sctp_conn_schedule 



The addition of sysctl_sloppy_sctp in sctp_conn_schedule resulted
in a use of ipvs before it was computed.  Hoist the computation of
ipvs earlier to avoid this problem.

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
parent 227b9e87

net/netfilter/ipvs/ip_vs_proto_sctp.c

+3 −2
Original line number Diff line number Diff line
@@ -20,6 +20,9 @@ sctp_conn_schedule(int af, struct sk_buff *skb, struct ip_vs_proto_data *pd, 
	sctp_sctphdr_t *sh, _sctph;

	__be16 _ports[2], *ports = NULL;



	net = skb_net(skb);

	ipvs = net_ipvs(net);



	if (likely(!ip_vs_iph_icmp(iph))) {

		sh = skb_header_pointer(skb, iph->len, sizeof(_sctph), &_sctph);

		if (sh) {
@@ -40,8 +43,6 @@ sctp_conn_schedule(int af, struct sk_buff *skb, struct ip_vs_proto_data *pd, 
		return 0;

	}



	net = skb_net(skb);

	ipvs = net_ipvs(net);

	rcu_read_lock();

	if (likely(!ip_vs_iph_inverse(iph)))

		svc = ip_vs_service_find(net, af, skb->mark, iph->protocol,