Commit 1e237994 authored by Zqiang's avatar Zqiang Committed by Paul E. McKenney
Browse files

rcu/kvfree: Invoke debug_rcu_bhead_unqueue() after checking bnode->gp_snap 



If kvfree_rcu_bulk() sees that the required grace period has failed to
elapse, it leaks the memory because readers might still be using it.
But in that case, the debug-objects subsystem still marks the relevant
structures as having been freed, even though they are instead being
leaked.

This commit fixes this mismatch by invoking debug_rcu_bhead_unqueue()
only when we are actually going to free the objects.

Signed-off-by: default avatarZqiang <qiang1.zhang@intel.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent f32276a3

kernel/rcu/tree.c

+1 −1
Original line number Diff line number Diff line
@@ -2922,8 +2922,8 @@ kvfree_rcu_bulk(struct kfree_rcu_cpu *krcp, 
	unsigned long flags;

	int i;



	debug_rcu_bhead_unqueue(bnode);

	if (!WARN_ON_ONCE(!poll_state_synchronize_rcu_full(&bnode->gp_snap))) {

		debug_rcu_bhead_unqueue(bnode);

		rcu_lock_acquire(&rcu_callback_map);

		if (idx == 0) { // kmalloc() / kfree().

			trace_rcu_invoke_kfree_bulk_callback(