Commit 1eade10f authored Mar 31, 2019 by Guenter Roeck

hwmon: (jc42) Use HWMON_CHANNEL_INFO macro



The HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood
of errors, and makes the code easier to read.

The conversion was done automatically with coccinelle. The semantic patch
used to make this change is as follows.

@r@
initializer list elements;
identifier i;
@@

-u32 i[] = {
-  elements,
-  0
-};

@s@
identifier r.i,j,ty;
@@

-struct hwmon_channel_info j = {
-       .type = ty,
-       .config = i,
-};

@script:ocaml t@
ty << s.ty;
elements << r.elements;
shorter;
elems;
@@

shorter :=
   make_ident (List.hd(List.rev (Str.split (Str.regexp "_") ty)));
elems :=
   make_ident
    (String.concat ","
     (List.map (fun x -> Printf.sprintf "\n\t\t\t   %s" x)
       (Str.split (Str.regexp " , ") elements)))

@@
identifier s.j,t.shorter;
identifier t.elems;
@@

- &j
+ HWMON_CHANNEL_INFO(shorter,elems)

This patch does not introduce functional changes. Many thanks to
Julia Lawall for providing the semantic patch.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 6f307b7c

drivers/hwmon/jc42.c

+5 −13

Original line number	Diff line number	Diff line
		@@ -451,20 +451,12 @@ static int jc42_detect(struct i2c_client client, struct i2c_board_info info)
		return -ENODEV;
		}

		static const u32 jc42_temp_config[] = {
		HWMON_T_INPUT \| HWMON_T_MIN \| HWMON_T_MAX \| HWMON_T_CRIT \|
		HWMON_T_MAX_HYST \| HWMON_T_CRIT_HYST \|
		HWMON_T_MIN_ALARM \| HWMON_T_MAX_ALARM \| HWMON_T_CRIT_ALARM,
		0
		};

		static const struct hwmon_channel_info jc42_temp = {
		.type = hwmon_temp,
		.config = jc42_temp_config,
		};

		static const struct hwmon_channel_info *jc42_info[] = {
		&jc42_temp,
		HWMON_CHANNEL_INFO(temp,
		HWMON_T_INPUT \| HWMON_T_MIN \| HWMON_T_MAX \|
		HWMON_T_CRIT \| HWMON_T_MAX_HYST \|
		HWMON_T_CRIT_HYST \| HWMON_T_MIN_ALARM \|
		HWMON_T_MAX_ALARM \| HWMON_T_CRIT_ALARM),
		NULL
		};