Commit 1ec32a4f authored by Marek Vasut's avatar Marek Vasut Committed by Shawn Guo
Browse files

soc: imx: imx8m-blk-ctrl: Make error prints useful 



Print the name of the power domain which failed to make the error
prints actually useful for finding the error.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Martyn Welch <martyn.welch@collabora.com>
Cc: Paul Elder <paul.elder@ideasonboard.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Acked-by: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 786dde1e

drivers/soc/imx/imx8m-blk-ctrl.c

+6 −3
Original line number Original line Diff line number Diff line
@@ -216,7 +216,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) 
	bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");

	bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");

	if (IS_ERR(bc->bus_power_dev))

	if (IS_ERR(bc->bus_power_dev))

		return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),

		return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),

				     "failed to attach power domain\n");

				     "failed to attach power domain \"bus\"\n");





	for (i = 0; i < bc_data->num_domains; i++) {

	for (i = 0; i < bc_data->num_domains; i++) {

		const struct imx8m_blk_ctrl_domain_data *data = &bc_data->domains[i];

		const struct imx8m_blk_ctrl_domain_data *data = &bc_data->domains[i];
@@ -238,7 +238,8 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) 
			dev_pm_domain_attach_by_name(dev, data->gpc_name);

			dev_pm_domain_attach_by_name(dev, data->gpc_name);

		if (IS_ERR(domain->power_dev)) {

		if (IS_ERR(domain->power_dev)) {

			dev_err_probe(dev, PTR_ERR(domain->power_dev),

			dev_err_probe(dev, PTR_ERR(domain->power_dev),

				      "failed to attach power domain\n");

				      "failed to attach power domain \"%s\"\n",

				      data->gpc_name);

			ret = PTR_ERR(domain->power_dev);

			ret = PTR_ERR(domain->power_dev);

			goto cleanup_pds;

			goto cleanup_pds;

		}

		}
@@ -251,7 +252,9 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) 




		ret = pm_genpd_init(&domain->genpd, NULL, true);

		ret = pm_genpd_init(&domain->genpd, NULL, true);

		if (ret) {

		if (ret) {

			dev_err_probe(dev, ret, "failed to init power domain\n");

			dev_err_probe(dev, ret,

				      "failed to init power domain \"%s\"\n",

				      data->gpc_name);

			dev_pm_domain_detach(domain->power_dev, true);

			dev_pm_domain_detach(domain->power_dev, true);

			goto cleanup_pds;

			goto cleanup_pds;

		}

		}