Commit 20ee0825 authored Jul 30, 2014 by Anand Jain Committed by Chris Mason Sep 17, 2014

btrfs: code optimize: BTRFS_ATTR_RW could set the mode



BTRFS_ATTR_RW could set the mode and be inline with BTRFS_ATTR

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>

parent 98b3d389

fs/btrfs/sysfs.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -401,7 +401,7 @@ static ssize_t btrfs_label_store(struct kobject *kobj,

	return ret;		return ret;
	}		}
	BTRFS_ATTR_RW(label, 0644, btrfs_label_show, btrfs_label_store);		BTRFS_ATTR_RW(label, btrfs_label_show, btrfs_label_store);

	static ssize_t btrfs_nodesize_show(struct kobject *kobj,		static ssize_t btrfs_nodesize_show(struct kobject *kobj,
	struct kobj_attribute a, char buf)		struct kobj_attribute a, char buf)

fs/btrfs/sysfs.h

+4 −3

Original line number	Original line	Diff line number	Diff line
	@@ -20,12 +20,13 @@ enum btrfs_feature_set {
	.store = _store, \		.store = _store, \
	}		}

	#define BTRFS_ATTR_RW(_name, _mode, _show, _store) \		#define BTRFS_ATTR_RW(_name, _show, _store) \
	static struct kobj_attribute btrfs_attr_##_name = \		static struct kobj_attribute btrfs_attr_##_name = \
	__INIT_KOBJ_ATTR(_name, _mode, _show, _store)		__INIT_KOBJ_ATTR(_name, 0644, _show, _store)

	#define BTRFS_ATTR(_name, _show) \		#define BTRFS_ATTR(_name, _show) \
	BTRFS_ATTR_RW(_name, 0444, _show, NULL)		static struct kobj_attribute btrfs_attr_##_name = \
			__INIT_KOBJ_ATTR(_name, 0444, _show, NULL)

	#define BTRFS_ATTR_PTR(_name) (&btrfs_attr_##_name.attr)		#define BTRFS_ATTR_PTR(_name) (&btrfs_attr_##_name.attr)