Unverified Commit 22205521 authored by Marco Felsch's avatar Marco Felsch Committed by Mark Brown
Browse files

ASoC: fsl_sai: add error message in case of missing imx-pcm-dma support 



If the imx-pcm-dma is required we need to have the module enabled. For
all NXP/FSL sound cards using the ASoC architecture this is the case but
in case of using the simple-audio-card sound card this isn't the case.

In such case the driver probe fails silently and the card isn't
available. It took a while to find the missing Kconfig. Make this easier
for others by printing a error if this the module isn't available but
required by the HW.

Signed-off-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Acked-by: default avatarShengjiu Wang <shengjiu.wang@gmail.com>
Link: https://lore.kernel.org/r/20220601092342.3328644-3-m.felsch@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f53f50ee

sound/soc/fsl/fsl_sai.c

+4 −1
Original line number Diff line number Diff line
@@ -1163,8 +1163,11 @@ static int fsl_sai_probe(struct platform_device *pdev) 
	 */

	if (sai->soc_data->use_imx_pcm) {

		ret = imx_pcm_dma_init(pdev);

		if (ret)

		if (ret) {

			if (!IS_ENABLED(CONFIG_SND_SOC_IMX_PCM_DMA))

				dev_err(dev, "Error: You must enable the imx-pcm-dma support!\n");

			goto err_pm_get_sync;

		}

	} else {

		ret = devm_snd_dmaengine_pcm_register(dev, NULL, 0);

		if (ret)