Commit 225c2926 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: vsp1: Fix spinlock in mixed IRQ context function 



The wpf_configure() function can be called both from IRQ and non-IRQ
contexts, use spin_lock_irqsave().

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent fc6e514a

drivers/media/platform/vsp1/vsp1_wpf.c

+3 −2
Original line number Diff line number Diff line
@@ -189,11 +189,12 @@ static void wpf_configure(struct vsp1_entity *entity, 
	if (params == VSP1_ENTITY_PARAMS_RUNTIME) {

		const unsigned int mask = BIT(WPF_CTRL_VFLIP)

					| BIT(WPF_CTRL_HFLIP);

		unsigned long flags;



		spin_lock(&wpf->flip.lock);

		spin_lock_irqsave(&wpf->flip.lock, flags);

		wpf->flip.active = (wpf->flip.active & ~mask)

				 | (wpf->flip.pending & mask);

		spin_unlock(&wpf->flip.lock);

		spin_unlock_irqrestore(&wpf->flip.lock, flags);



		outfmt = (wpf->alpha << VI6_WPF_OUTFMT_PDV_SHIFT) | wpf->outfmt;