Commit 22dfe657 authored by Lee Jones's avatar Lee Jones Committed by Greg Kroah-Hartman
Browse files

usb: chipidea: udc: Add missing descriptions for function arg 'ci' 



Looks like a very popular argument to omit descriptions for.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/chipidea/udc.c:80: warning: Function parameter or member 'ci' not described in 'hw_device_state'
 drivers/usb/chipidea/udc.c:100: warning: Function parameter or member 'ci' not described in 'hw_ep_flush'
 drivers/usb/chipidea/udc.c:121: warning: Function parameter or member 'ci' not described in 'hw_ep_disable'
 drivers/usb/chipidea/udc.c:136: warning: Function parameter or member 'ci' not described in 'hw_ep_enable'
 drivers/usb/chipidea/udc.c:170: warning: Function parameter or member 'ci' not described in 'hw_ep_get_halt'
 drivers/usb/chipidea/udc.c:185: warning: Function parameter or member 'ci' not described in 'hw_ep_prime'
 drivers/usb/chipidea/udc.c:215: warning: Function parameter or member 'ci' not described in 'hw_ep_set_halt'
 drivers/usb/chipidea/udc.c:238: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed'
 drivers/usb/chipidea/udc.c:251: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_complete'
 drivers/usb/chipidea/udc.c:263: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active'
 drivers/usb/chipidea/udc.c:277: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard'
 drivers/usb/chipidea/udc.c:288: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard'
 drivers/usb/chipidea/udc.c:300: warning: Function parameter or member 'ci' not described in 'hw_usb_set_address'
 drivers/usb/chipidea/udc.c:312: warning: Function parameter or member 'ci' not described in 'hw_usb_reset'

Cc: Peter Chen <Peter.Chen@nxp.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200703174148.2749969-12-lee.jones@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5722a8ef

drivers/usb/chipidea/udc.c

+11 −1
Original line number Diff line number Diff line
@@ -72,6 +72,7 @@ static inline int ep_to_bit(struct ci_hdrc *ci, int n) 


/**

 * hw_device_state: enables/disables interrupts (execute without interruption)

 * @ci: the controller

 * @dma: 0 => disable, !0 => enable and set dma engine

 *

 * This function returns an error code
@@ -91,6 +92,7 @@ static int hw_device_state(struct ci_hdrc *ci, u32 dma) 


/**

 * hw_ep_flush: flush endpoint fifo (execute without interruption)

 * @ci: the controller

 * @num: endpoint number

 * @dir: endpoint direction

 *
@@ -112,6 +114,7 @@ static int hw_ep_flush(struct ci_hdrc *ci, int num, int dir) 


/**

 * hw_ep_disable: disables endpoint (execute without interruption)

 * @ci: the controller

 * @num: endpoint number

 * @dir: endpoint direction

 *
@@ -126,6 +129,7 @@ static int hw_ep_disable(struct ci_hdrc *ci, int num, int dir) 


/**

 * hw_ep_enable: enables endpoint (execute without interruption)

 * @ci: the controller

 * @num:  endpoint number

 * @dir:  endpoint direction

 * @type: endpoint type
@@ -161,6 +165,7 @@ static int hw_ep_enable(struct ci_hdrc *ci, int num, int dir, int type) 


/**

 * hw_ep_get_halt: return endpoint halt status

 * @ci: the controller

 * @num: endpoint number

 * @dir: endpoint direction

 *
@@ -175,6 +180,7 @@ static int hw_ep_get_halt(struct ci_hdrc *ci, int num, int dir) 


/**

 * hw_ep_prime: primes endpoint (execute without interruption)

 * @ci: the controller

 * @num:     endpoint number

 * @dir:     endpoint direction

 * @is_ctrl: true if control endpoint
@@ -205,6 +211,7 @@ static int hw_ep_prime(struct ci_hdrc *ci, int num, int dir, int is_ctrl) 
/**

 * hw_ep_set_halt: configures ep halt & resets data toggle after clear (execute

 *                 without interruption)

 * @ci: the controller

 * @num:   endpoint number

 * @dir:   endpoint direction

 * @value: true => stall, false => unstall
@@ -243,6 +250,7 @@ static int hw_port_is_high_speed(struct ci_hdrc *ci) 
/**

 * hw_test_and_clear_complete: test & clear complete status (execute without

 *                             interruption)

 * @ci: the controller

 * @n: endpoint number

 *

 * This function returns complete status
@@ -291,6 +299,7 @@ static int hw_test_and_set_setup_guard(struct ci_hdrc *ci) 


/**

 * hw_usb_set_address: configures USB address (execute without interruption)

 * @ci: the controller

 * @value: new USB address

 *

 * This function explicitly sets the address, without the "USBADRA" (advance)
@@ -610,8 +619,9 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) 
	return ret;

}



/*

/**

 * free_pending_td: remove a pending request for the endpoint

 * @ci: the controller

 * @hwep: endpoint

 */

static void free_pending_td(struct ci_hw_ep *hwep)