Commit 22fac49f authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Add a few more debugs for failed framebuffer creation 



Most of the .fb_create() failure paths are annotated but there
are a few that seem capable of failing silently (well, higher
level code should print something, just not anything actually
useful). Drop a few more hints into the log to aid in debugging.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230215222426.26085-2-ville.syrjala@linux.intel.com


Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
parent 5ed88f96

drivers/gpu/drm/i915/display/intel_fb.c

+2 −0
Original line number Diff line number Diff line
@@ -2007,6 +2007,7 @@ int intel_framebuffer_init(struct intel_framebuffer *intel_fb, 


		vm = intel_dpt_create(intel_fb);

		if (IS_ERR(vm)) {

			drm_dbg_kms(&dev_priv->drm, "failed to create DPT\n");

			ret = PTR_ERR(vm);

			goto err;

		}
@@ -2049,6 +2050,7 @@ intel_user_framebuffer_create(struct drm_device *dev, 
	if (HAS_LMEM(i915) && !i915_gem_object_can_migrate(obj, INTEL_REGION_LMEM_0)) {

		/* object is "remote", not in local memory */

		i915_gem_object_put(obj);

		drm_dbg_kms(&i915->drm, "framebuffer must reside in local memory\n");

		return ERR_PTR(-EREMOTE);

	}