Commit 2312e844 authored by Don Brace's avatar Don Brace Committed by Martin K. Petersen
Browse files

scsi: smartpqi: Fix rare SAS transport memory leak 



Free rphy when pqi_sas_port_add_rphy() returns an error.

If pqi_sas_port_add_rphy() returns an error, the 'rphy' allocated in
sas_end_device_alloc() needs to be freed.

It should be noted that no issues were ever reported.

Reviewed-by: default avatarScott Benesh <scott.benesh@microchip.com>
Reviewed-by: default avatarScott Teel <scott.teel@microchip.com>
Reviewed-by: default avatarMike McGowen <mike.mcgowen@microchip.com>
Reviewed-by: default avatarKevin Barnett <kevin.barnett@microchip.com>
Suggested-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarDon Brace <don.brace@microchip.com>
Link: https://lore.kernel.org/r/20230428153712.297638-5-don.brace@microchip.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 889cda36

drivers/scsi/smartpqi/smartpqi_sas_transport.c

+3 −1
Original line number Diff line number Diff line
@@ -293,10 +293,12 @@ int pqi_add_sas_device(struct pqi_sas_node *pqi_sas_node, 


	rc = pqi_sas_port_add_rphy(pqi_sas_port, rphy);

	if (rc)

		goto free_sas_port;

		goto free_sas_rphy;



	return 0;



free_sas_rphy:

	sas_rphy_free(rphy);

free_sas_port:

	pqi_free_sas_port(pqi_sas_port);

	device->sas_port = NULL;