Commit 24156df0 authored by Liang He's avatar Liang He Committed by Michael Ellerman
Browse files

powerpc/83xx: Add missing of_node_put() in mpc832x_spi_init() 



In mpc832x_spi_init(), hold the reference returned by
of_find_compatible_node() and use it to call of_node_put() for refcount
balance.

Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220621080932.4081935-1-windhl@126.com
parent cc0dd82c

arch/powerpc/platforms/83xx/mpc832x_rdb.c

+5 −1
Original line number Diff line number Diff line
@@ -162,6 +162,8 @@ static struct spi_board_info mpc832x_spi_boardinfo = { 


static int __init mpc832x_spi_init(void)

{

	struct device_node *np;



	par_io_config_pin(3,  0, 3, 0, 1, 0); /* SPI1 MOSI, I/O */

	par_io_config_pin(3,  1, 3, 0, 1, 0); /* SPI1 MISO, I/O */

	par_io_config_pin(3,  2, 3, 0, 1, 0); /* SPI1 CLK,  I/O */
@@ -175,7 +177,9 @@ static int __init mpc832x_spi_init(void) 
	 * Don't bother with legacy stuff when device tree contains

	 * mmc-spi-slot node.

	 */

	if (of_find_compatible_node(NULL, NULL, "mmc-spi-slot"))

	np = of_find_compatible_node(NULL, NULL, "mmc-spi-slot");

	of_node_put(np);

	if (np)

		return 0;

	return fsl_spi_init(&mpc832x_spi_boardinfo, 1, mpc83xx_spi_cs_control);

}