Commit 25ef42f3 authored by Christian Gromm's avatar Christian Gromm Committed by Greg Kroah-Hartman
Browse files

staging: most: fix race condition in AIM networking 



If the network device is being opened right after it has been registered
via function register_netdev(), the device state is not yet consistent in
the context of function ndo_open(). This patch cares about having the
initialization done right, before the networking device is registered.

Signed-off-by: default avatarAndrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bf358040

drivers/staging/most/aim-network/networking.c

+3 −0
Original line number Diff line number Diff line
@@ -356,10 +356,13 @@ static int aim_probe_channel(struct most_interface *iface, int channel_idx, 
		}



		nd->dev = dev;

		ch->ch_id = channel_idx;

		ch->linked = true;



		dev->ml_priv = nd;

		if (register_netdev(dev)) {

			pr_err("registering net device failed\n");

			ch->linked = false;

			free_netdev(dev);

			return -EINVAL;

		}